Skip to content

Add support for configuring the Pod Snapshots feature #16096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shuyama1 merged 2 commits into from
Jan 14, 2026
Merged

Add support for configuring the Pod Snapshots feature #16096

shuyama1 merged 2 commits into from
Jan 14, 2026
+43 −0

Conversation

@saketjajoo
Copy link
Member

@saketjajoo saketjajoo commented Jan 8, 2026 •
edited by shuyama1
Loading

The GKE Pod Snapshots feature is rolled out in a Public Preview mode. This change aims to update the terraform provider to include the config to enable/disable this feature when using the beta APIs.

Internal Ref: b/445922392.
Cross Ref: #15262 - this PR was created before the API change was rolled out to get an initial review and got closed due to inactivity. Now that the API change is rolled out in beta (public preview), I'm create this PR to resume the work.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `pod_snapshot_config` field to `google_container_cluster` resource (beta)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 8, 2026
@github-actions github-actions bot requested a review from shuyama1 January 8, 2026 00:16
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@saketjajoo
Copy link
Member Author

saketjajoo commented Jan 8, 2026

/cc @CoderSherlock

@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 8, 2026
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 8, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [addons_config.pod_snapshot_config.enabled]

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 8, 2026

Tests analytics

Total tests: 272
Passed tests: 256
Skipped tests: 15
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withAddons

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 8, 2026

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withAddons [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@CoderSherlock
Copy link

CoderSherlock commented Jan 8, 2026

/LGTM

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

shuyama1
shuyama1 reviewed Jan 13, 2026
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. only some nit-picks for formatting. Should be good to go after!

@github-actions github-actions bot requested a review from shuyama1 January 13, 2026 21:25
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [addons_config.pod_snapshot_config.enabled]

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Tests analytics

Total tests: 272
Passed tests: 257
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [addons_config.pod_snapshot_config.enabled]

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Tests analytics

Total tests: 272
Passed tests: 257
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [addons_config.pod_snapshot_config.enabled]

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 13, 2026

Tests analytics

Total tests: 272
Passed tests: 257
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 14, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 4 files changed, 43 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [addons_config.pod_snapshot_config.enabled]

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 14, 2026

Tests analytics

Total tests: 272
Passed tests: 257
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@shuyama1 shuyama1 added this pull request to the merge queue Jan 14, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 124c484 Jan 14, 2026
24 checks passed
@modular-magician modular-magician mentioned this pull request Jan 14, 2026
Merged
This was referenced Jan 14, 2026
Merged
Merged
@saketjajoo saketjajoo deleted the gke-pod-snapshots branch January 14, 2026 01:39
amukul-25 pushed a commit to amukul-25/magic-modules that referenced this pull request Jan 14, 2026
@saketjajoo @amukul-25
Add support for configuring the Pod Snapshots feature (GoogleCloudPla…
911b244 
…tform#16096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees

No one assigned

Labels

service/container

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saketjajoo @modular-magician @CoderSherlock @shuyama1